feat: add useAttribute hook for boolean property ↔ attribute reflection#99
Draft
cristinecula wants to merge 1 commit into
Draft
feat: add useAttribute hook for boolean property ↔ attribute reflection#99cristinecula wants to merge 1 commit into
cristinecula wants to merge 1 commit into
Conversation
Add a standalone useAttribute hook that provides bidirectional boolean
property ↔ attribute sync with built-in loop prevention.
API: const [opened, setOpened] = useAttribute('opened');
- Always reflects: true → setAttribute('', ''), false → removeAttribute
- Dispatches cancelable *-changed events (same convention as useProperty)
- Supports function updater: setter(prev => !prev)
- Supports lift() pattern for parent-controlled state
- Reads initial attribute value from host element
- Respects parent-provided .prop= bindings
- Throws when used in virtual components
- Handles kebab-case ↔ camelCase conversion
Also adds reflectingSymbol guard + null→false coercion to
attributeChangedCallback in component.ts to prevent feedback loops
when the hook reflects property changes back to attributes.
Closes NEO-1055
|
✅ Deploy Preview for pionjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a standalone
useAttributehook for bidirectional boolean property ↔ attribute sync with built-in loop prevention. Addresses NEO-1055.API
true, absent =falsesetOpened(true)→setAttribute('opened', ''),setOpened(false)→removeAttribute('opened')opened-changedevent (same convention asuseProperty)setOpened(prev => !prev)lift()pattern for parent-controlled state.prop=bindingsopen-on-focus→openOnFocus)Consumer usage
Changes
src/use-attribute.tsuseAttributehook implementationsrc/symbols.tsreflectingSymbolfor loop preventionsrc/component.tsreflectingSymbolguard +null→falsecoercion inattributeChangedCallbacksrc/core.tsuseAttributetest/use-attribute.test.tsHow it differs from
usePropertyusePropertyuseAttributefalse(boolean semantics)Test results
All 81 tests pass (13 new + 68 existing), 96.5% code coverage, zero regressions.